From 38bef0a38bf907a54c193ab063b4830788398edc Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Sat, 9 Feb 2008 18:48:56 -0500 Subject: Make a pending ReplayPointer happen before moving/showing/hiding a window in an action. Commit c907f5af4ad16b1 broke kdesktop again, so we have to fix it at an even finer level. --- openbox/actions.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) (limited to 'openbox/actions.c') diff --git a/openbox/actions.c b/openbox/actions.c index b7ba5b44..90a7719b 100644 --- a/openbox/actions.c +++ b/openbox/actions.c @@ -36,7 +36,6 @@ static ObActionsAct* actions_build_act_from_string(const gchar *name); static ObActionsAct *interactive_act = NULL; static guint interactive_initial_state = 0; -static gboolean replay_pointer = FALSE; struct _ObActionsDefinition { guint ref; @@ -224,16 +223,6 @@ static void actions_setup_data(ObActionsData *data, data->client = client; } -void actions_set_need_pointer_replay_before_move(gboolean replay) -{ - replay_pointer = replay; -} - -gboolean actions_get_need_pointer_replay_before_move() -{ - return replay_pointer; -} - void actions_run_acts(GSList *acts, ObUserAction uact, guint state, @@ -346,14 +335,8 @@ gboolean actions_interactive_input_event(XEvent *e) void actions_client_move(ObActionsData *data, gboolean start) { static gulong ignore_start = 0; - if (start) { + if (start) ignore_start = event_start_ignore_all_enters(); - if (replay_pointer) { - /* replay the pointer event before any windows move */ - XAllowEvents(ob_display, ReplayPointer, event_curtime); - replay_pointer = FALSE; - } - } else if (config_focus_follow && data->context != OB_FRAME_CONTEXT_CLIENT) { -- cgit v1.2.3 From 619fd7e666944aa83c636d14cd2777cbd5dc1094 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Wed, 13 Feb 2008 10:19:52 -0500 Subject: don't force fake enter events while there is a grab on the pointer. this fixes focus switching during a move/resize from mouse-button-bound actions. --- openbox/actions.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'openbox/actions.c') diff --git a/openbox/actions.c b/openbox/actions.c index 90a7719b..32b3d274 100644 --- a/openbox/actions.c +++ b/openbox/actions.c @@ -347,8 +347,14 @@ void actions_client_move(ObActionsData *data, gboolean start) that moves windows our from under the cursor, the enter event will come as a GrabNotify which is ignored, so this makes a fake enter event + + don't do this if there is a grab on the pointer. enter events + are ignored during a grab, so don't force fake ones when they + should be ignored */ - if ((c = client_under_pointer()) && c != data->client) { + if ((c = client_under_pointer()) && c != data->client && + !grab_on_pointer()) + { ob_debug_type(OB_DEBUG_FOCUS, "Generating fake enter because we did a " "mouse-event action"); -- cgit v1.2.3