From fa0ae17adbc8f73b707c33836d37841e81b9303a Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Thu, 5 Nov 2009 22:29:38 +0100 Subject: Make clang happier Add asserts to default: in switch statements Store pointed to variables locally so it knows they don't change Remove some dead assignments Mark ob_exit_with_error as noreturn Use "%s", msg instead of just msg to printf style functions Use the c_pfocus variable --- openbox/event.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'openbox/event.c') diff --git a/openbox/event.c b/openbox/event.c index 3f5c1543..2c73289e 100644 --- a/openbox/event.c +++ b/openbox/event.c @@ -417,6 +417,7 @@ static void print_focusevent(XEvent *e) case NotifyGrab: modestr="NotifyGrab"; break; case NotifyUngrab: modestr="NotifyUngrab"; break; case NotifyWhileGrabbed: modestr="NotifyWhileGrabbed"; break; + default: g_assert_not_reached(); } switch (detail) { case NotifyAncestor: detailstr="NotifyAncestor"; break; @@ -427,6 +428,7 @@ static void print_focusevent(XEvent *e) case NotifyPointer: detailstr="NotifyPointer"; break; case NotifyPointerRoot: detailstr="NotifyPointerRoot"; break; case NotifyDetailNone: detailstr="NotifyDetailNone"; break; + default: g_assert_not_reached(); } if (mode == NotifyGrab || mode == NotifyUngrab) @@ -1598,6 +1600,8 @@ static void event_handle_client(ObClient *client, XEvent *e) client->shaped_input = ((XShapeEvent*)e)->shaped; kind = ShapeInput; break; + default: + g_assert_not_reached(); } frame_adjust_shape_kind(client->frame, kind); } -- cgit v1.2.3