From d658612cac44ccc1406aea1bad48c851016e4751 Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Tue, 7 Aug 2007 03:52:28 +0200 Subject: Fix another memleak --- openbox/place.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'openbox/place.c') diff --git a/openbox/place.c b/openbox/place.c index 7c20c79f..9892836e 100644 --- a/openbox/place.c +++ b/openbox/place.c @@ -134,6 +134,8 @@ static Rect **pick_head(ObClient *c) for (i = 0; i < screen_num_monitors; ++i) area[i] = screen_area(c->desktop, choice[i], NULL); + g_free(choice); + return area; } -- cgit v1.2.3 From d3ff019f53f02afe0c7116a99f65ffb8d622e889 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Mon, 6 Aug 2007 22:12:20 -0400 Subject: more clear code? --- openbox/place.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'openbox/place.c') diff --git a/openbox/place.c b/openbox/place.c index 9892836e..851e4f8f 100644 --- a/openbox/place.c +++ b/openbox/place.c @@ -182,7 +182,7 @@ static GSList* area_remove(GSList *list, Rect *a) if (!RECT_INTERSECTS_RECT(*r, *a)) { result = g_slist_prepend(result, r); - r = NULL; /* dont free it */ + /* dont free r, it's moved to the result list */ } else { Rect isect, extra; @@ -217,9 +217,10 @@ static GSList* area_remove(GSList *list, Rect *a) r->width, RECT_BOTTOM(*r) - RECT_BOTTOM(isect)); result = area_add(result, &extra); } - } - g_free(r); + /* 'r' is not being added to the result list, so free it */ + g_free(r); + } } g_slist_free(list); return result; -- cgit v1.2.3 From 1492bd0e7d92b3c7c1ca6adfe46dab4b8c2d3fed Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Tue, 4 Sep 2007 06:22:28 +0200 Subject: Fix shadowed variables --- openbox/place.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'openbox/place.c') diff --git a/openbox/place.c b/openbox/place.c index 851e4f8f..aa572db2 100644 --- a/openbox/place.c +++ b/openbox/place.c @@ -254,8 +254,6 @@ static gboolean place_nooverlap(ObClient *c, gint *x, gint *y) /* try ignoring different things to find empty space */ for (ignore = 0; ignore < IGNORE_END && !ret; ignore++) { - guint i; - /* try all monitors in order of preference */ for (i = 0; i < screen_num_monitors && !ret; ++i) { GList *it; -- cgit v1.2.3