summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMikael Magnusson <mikachu@gmail.com>2014-10-28 05:20:10 +0100
committerMikael Magnusson <mikachu@gmail.com>2014-10-28 05:42:28 +0100
commit122e2a81d3899f918de81a735061776193ddeed8 (patch)
tree8c40c2fbcce57451ac16bd794dd82b7ec3fc140c
parent1491e196f3d05152fab127eb9cff3146a68a20a8 (diff)
Some fixes found by coverity for things used before a null check
In the second case, we actually check the wrong variable.
-rw-r--r--obrender/image.c5
-rw-r--r--obt/xml.c2
2 files changed, 4 insertions, 3 deletions
diff --git a/obrender/image.c b/obrender/image.c
index 8ff9bf10..fb5f40bc 100644
--- a/obrender/image.c
+++ b/obrender/image.c
@@ -243,7 +243,7 @@ RrImageSet* RrImageSetMergeSets(RrImageSet *b, RrImageSet *a)
gint n_original, n_resized, tmp;
GSList *it;
- const gint max_resized = a->cache->max_resized_saved;
+ gint max_resized;
if (!a)
return b;
@@ -251,7 +251,6 @@ RrImageSet* RrImageSetMergeSets(RrImageSet *b, RrImageSet *a)
return a;
if (a == b)
return b;
-
/* the original and resized picture lists in an RrImageSet are kept ordered
as newest to oldest. we don't have timestamps for them, so we cannot
preserve this in the merged RrImageSet exactly. a decent approximation,
@@ -264,6 +263,8 @@ RrImageSet* RrImageSetMergeSets(RrImageSet *b, RrImageSet *a)
g_assert(b->cache == a->cache);
+ max_resized = a->cache->max_resized_saved;
+
a_i = b_i = merged_i = 0;
n_original = a->n_original + b->n_original;
original = g_new(RrImagePic*, n_original);
diff --git a/obt/xml.c b/obt/xml.c
index 223ad02b..f200ae75 100644
--- a/obt/xml.c
+++ b/obt/xml.c
@@ -281,7 +281,7 @@ gboolean obt_xml_load_mem(ObtXmlInst *i,
xmlResetLastError();
i->doc = xmlParseMemory(data, len);
- if (i) {
+ if (i->doc) {
i->root = xmlDocGetRootElement(i->doc);
if (!i->root) {
xmlFreeDoc(i->doc);